Repository navigation
fork seams: announce the MCP profile hooks line of PR 528 (step 1) - #533
Merged
Merged
Conversation
Announces one more ClaudeAdapterV2.ts line for MCP profiles part 2: the adapter merges the profile's PreToolUse hook (the call-time guard that refuses a tool call to a server outside the thread's profile) into its own hooks. Joins the existing announcement of 2026-11-19 and updates the entry's why. List only; #528 adds the line and moves it to "added". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 (list only) for the fix round of #528, as docs/fork/updates.md "Adding a seam line" asks.
What: one more announced line in the
apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.tsentry:It goes inside
makeClaudeQueryOptions'hooks: { … }block. It merges the MCP profile'sPreToolUsehook into the adapter's own hooks (SubagentStart,Stop). Without it, upstream's hooks object replaces the profile's hook, because the profile options are spread earlier in the same object. The hook is #528's call-time guard: it refuses a tool call to an MCP server outside the thread's profile (review finding B1).sinceis unchanged, as this is the same day.whygains the hook, in the same words feat(server): Claude threads apply their MCP profile's outside servers #528 uses, so the merge into feat(server): Claude threads apply their MCP profile's outside servers #528 stays simple.After this merges, #528 (which adds the line and lists it under
added) needs main merged in once more; the list conflict resolves to #528's side.🤖 Generated with Claude Code